Fix unit/integration tests related with connection.connect and bolt-agent for Deno #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gent for Deno The test code related with `connection.connect` were calling the method without the bolt agent causing all kind of errors. Add the bolt agent to the calls and expectations solves the issue. `Deno.osRelease()` and the flag `--allow-sys` are not available in Deno 1.19.2. The missing flag was causing the test don't even start. The method unexistance was causing the code fails because is calling a non existing method. The missing flag is solved by using `--allow-all` instead. This is a more permissive flag, but it is not a big deal in test env. The absence of `Deno.osRelease()` is solved by not setting the release when this method is not available. This might be an issue for old Deno users, but it's not a blocker.
ConorNeo
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test code related with
connection.connectwere calling the method without the bolt agent causing all kind of errors. Add the bolt agent to the calls and expectations solves the issue.Deno.osRelease()and the flag--allow-sysare not available in Deno 1.19.2. The missing flag was causing the test don't even start. The method un-existence was causing the code fails because is calling a non existing method.The missing flag is solved by using
--allow-allinstead. This is a more permissive flag, but it is not a big deal in test env.The absence of
Deno.osRelease()is solved by not setting the release when this method is not available. This might be an issue for old Deno users, but it's not a blocker.